openinx commented on a change in pull request #1978:
URL: https://github.com/apache/iceberg/pull/1978#discussion_r549615472
##########
File path: flink/src/main/java/org/apache/iceberg/flink/FlinkCatalog.java
##########
@@ -447,10 +459,12 @@ private static void validateFlinkTable(CatalogBaseTable
table) {
if (!schema.getWatermarkSpecs().isEmpty()) {
throw new UnsupportedOperationException("Creating table with watermark
specs is not supported yet.");
}
+ }
- if (schema.getPrimaryKey().isPresent()) {
- throw new UnsupportedOperationException("Creating table with primary key
is not supported yet.");
- }
+ private static List<String> toEqualityColumns(TableSchema schema) {
Review comment:
Yes, it should track ID here. I was thinking that it could be a
temporary solution before introducing the primary key specification.
Considering the renaming issue, it seems not a good idea to track column names
in iceberg properties.
I will create another PR to introduce the primary key specification based on
the discussion from
[here](https://github.com/apache/iceberg/pull/1974#discussion_r547616494).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
