LuciferYang commented on code in PR #838:
URL: https://github.com/apache/iceberg-cpp/pull/838#discussion_r3636860079
##########
.github/workflows/cpp-linter.yml:
##########
@@ -91,24 +91,38 @@ jobs:
with:
path: ${{ github.workspace }}/.sccache
key: sccache-cpp-linter-ubuntu-${{ github.run_id }}
- - uses:
cpp-linter/cpp-linter-action@0f6d1b8d7e38b584cbee606eb23d850c217d54f8 # v2.15.1
+ - uses: actions/setup-python@ece7cb06caefa5fff74198d8649806c4678c61a1 #
v6.3.0
+ if: github.event_name == 'pull_request'
+ with:
+ python-version: '3.13'
+ - name: Install cpp-linter and clang tools
+ if: github.event_name == 'pull_request'
+ run: python -m pip install "cpp-linter==1.13.0" "clang-format==22.1.8"
"clang-tidy==22.1.8"
Review Comment:
Split them as you suggested: `CLANG_FORMAT_VERSION` (22.1.5, matching
pre-commit) and `CLANG_TIDY_VERSION` (22.1.8, since clang-tidy has no 22.1.5 on
PyPI). Added a comment on the format version pointing at
`.pre-commit-config.yaml` as the sync reminder.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
