Copilot commented on code in PR #838:
URL: https://github.com/apache/iceberg-cpp/pull/838#discussion_r3636953475
##########
.github/workflows/cpp-linter.yml:
##########
@@ -91,24 +96,40 @@ jobs:
with:
path: ${{ github.workspace }}/.sccache
key: sccache-cpp-linter-ubuntu-${{ github.run_id }}
- - uses:
cpp-linter/cpp-linter-action@0f6d1b8d7e38b584cbee606eb23d850c217d54f8 # v2.15.1
+ - uses: actions/setup-python@ece7cb06caefa5fff74198d8649806c4678c61a1 #
v6.3.0
+ if: github.event_name == 'pull_request'
+ with:
+ python-version: '3.13'
+ - name: Install cpp-linter and clang tools
+ if: github.event_name == 'pull_request'
+ run: |
+ python -m pip install --upgrade pip
+ python -m pip install "cpp-linter==${CPP_LINTER_VERSION}"
"clang-format==${CLANG_FORMAT_VERSION}" "clang-tidy==${CLANG_TIDY_VERSION}"
+ - name: Run cpp-linter
id: linter
if: github.event_name == 'pull_request'
continue-on-error: true
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- with:
- style: file
- tidy-checks: ''
- version: 22
- files-changed-only: true
- lines-changed-only: true
- thread-comments: true
- ignore: 'build|cmake_modules|ci|src/iceberg/catalog/hive/gen-cpp'
- database: build
- verbosity: 'debug'
- # need '-fno-builtin-std-forward_like', see
https://github.com/llvm/llvm-project/issues/101614
- extra-args: '-std=c++23 -I$PWD/src -I$PWD/build/src
-I$PWD/build/_deps/sqlpp23-src/include -I/usr/include/postgresql
-I/usr/include/mysql -fno-builtin-std-forward_like'
+ # need '-fno-builtin-std-forward_like', see
https://github.com/llvm/llvm-project/issues/101614
+ run: |
+ cpp-linter \
+ --style=file \
+ --tidy-checks='' \
+ --version="${CLANG_FORMAT_VERSION%%.*}" \
+ --files-changed-only=true \
Review Comment:
`${CLANG_FORMAT_VERSION%%.*}` relies on Bash-specific parameter expansion.
GitHub Actions currently defaults to `bash` on Ubuntu, but this can break if
the job/workflow shell defaults change. Consider making this robust by
explicitly setting `shell: bash` for the step, or by computing/pinning the
major version in an env var (e.g., `CLANG_VERSION_MAJOR: '22'`) and using that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
