Copilot commented on code in PR #838:
URL: https://github.com/apache/iceberg-cpp/pull/838#discussion_r3636953409
##########
.github/workflows/cpp-linter.yml:
##########
@@ -48,6 +48,11 @@ jobs:
env:
SCCACHE_DIR: ${{ github.workspace }}/.sccache
SCCACHE_CACHE_SIZE: "2G"
+ CPP_LINTER_VERSION: "1.13.0"
+ # clang-format is kept in sync with .pre-commit-config.yaml; clang-tidy
is
+ # pinned separately because that version is not published on PyPI.
+ CLANG_FORMAT_VERSION: "22.1.5"
+ CLANG_TIDY_VERSION: "22.1.8"
Review Comment:
The comment says the pinned `clang-tidy` version is not published on PyPI,
but the workflow installs `clang-tidy==${CLANG_TIDY_VERSION}` via `pip`. If
that statement is accurate, this step will fail at runtime. Either (a) adjust
the installation method for `clang-tidy` (e.g., install via apt/LLVM packages
and ensure it’s on `PATH`), or (b) correct the comment / version pins to
reflect the actual source and availability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
