danielcweeks commented on code in PR #15703:
URL: https://github.com/apache/iceberg/pull/15703#discussion_r3639138889
##########
core/src/main/java/org/apache/iceberg/rest/auth/AuthProperties.java:
##########
@@ -34,8 +34,12 @@ private AuthProperties() {}
"org.apache.iceberg.rest.auth.NoopAuthManager";
public static final String AUTH_MANAGER_IMPL_BASIC =
"org.apache.iceberg.rest.auth.BasicAuthManager";
- public static final String AUTH_MANAGER_IMPL_OAUTH2 =
+ static final String AUTH_MANAGER_IMPL_OAUTH2_LEGACY =
"org.apache.iceberg.rest.auth.OAuth2Manager";
+ static final String AUTH_MANAGER_IMPL_OAUTH2_NEW =
+ "org.apache.iceberg.rest.auth.oauth2.OAuth2Manager";
+ public static final String AUTH_MANAGER_IMPL_OAUTH2 =
+ AUTH_MANAGER_IMPL_OAUTH2_LEGACY; // TODO switch to new manager
Review Comment:
Strong preference to not include `TODO`, we already call it out
`LEGACY/NEW`, we should drop this comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
