rdblue commented on code in PR #15703:
URL: https://github.com/apache/iceberg/pull/15703#discussion_r3646606803
##########
core/src/main/java/org/apache/iceberg/rest/auth/OAuth2Manager.java:
##########
@@ -40,6 +40,11 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+/**
+ * @deprecated will be removed in 1.14.0, use {@link
+ * org.apache.iceberg.rest.auth.oauth2.OAuth2Manager} instead.
+ */
+@Deprecated
Review Comment:
I don't think we should deprecate these in this PR. Before we deprecate, we
need to fully replace this. Plus, this is unrelated and can go in a separate PR
so this one doesn't require touching so many files. It's a best practice to
keep unrelated changes in separate PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
