evindj commented on code in PR #847:
URL: https://github.com/apache/iceberg-cpp/pull/847#discussion_r3651102656
##########
src/iceberg/util/config.h:
##########
@@ -54,7 +54,7 @@ U DefaultFromString(const std::string& val) {
if constexpr (std::is_same_v<U, std::string>) {
return val;
} else if constexpr (std::is_same_v<U, bool>) {
- return val == "true";
+ return StringUtils::EqualsIgnoreCase(val, "true");
Review Comment:
pretty sure you did but it would ne nice to check for other places in the
code base where similar comparison with literals is made.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
