fallintoplace commented on code in PR #847:
URL: https://github.com/apache/iceberg-cpp/pull/847#discussion_r3651166882
##########
src/iceberg/util/config.h:
##########
@@ -54,7 +54,7 @@ U DefaultFromString(const std::string& val) {
if constexpr (std::is_same_v<U, std::string>) {
return val;
} else if constexpr (std::is_same_v<U, bool>) {
- return val == "true";
+ return StringUtils::EqualsIgnoreCase(val, "true");
Review Comment:
Good call. I found the same case-sensitive parsing in the S3 properties and
pushed a follow-up for `s3.ssl.enabled` and `s3.path-style-access`. The other
literal comparisons I found are Avro schema attributes rather than
configuration properties, so I left those unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
