wgtmac commented on code in PR #801:
URL: https://github.com/apache/iceberg-cpp/pull/801#discussion_r3675785984
##########
src/iceberg/inspect/snapshots_table.cc:
##########
@@ -65,4 +68,50 @@ Result<std::unique_ptr<SnapshotsTable>> SnapshotsTable::Make(
return std::unique_ptr<SnapshotsTable>(new SnapshotsTable(std::move(table)));
}
+Result<ArrowArray> SnapshotsTable::Scan(
+ const std::optional<SnapshotSelection>& /*snapshot_selection*/) {
Review Comment:
Silently ignoring an invalid selection diverges from Java.
`SnapshotScan.useSnapshot`, `useRef`, and `asOfTime` validate or resolve the
requested snapshot before `SnapshotsTable` returns all known snapshots. With
this implementation, `Scan({.snapshot_id = 999})` succeeds and returns
unrelated rows. Please validate the selector (or reject a non-null selection as
unsupported) instead of treating invalid input as an unqualified scan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
