WZhuo commented on code in PR #801:
URL: https://github.com/apache/iceberg-cpp/pull/801#discussion_r3689127851
##########
src/iceberg/inspect/metadata_table.h:
##########
@@ -23,14 +23,28 @@
/// \brief Define base APIs for metadata tables.
#include <memory>
+#include <optional>
+#include <string>
+#include "iceberg/arrow_c_data.h"
#include "iceberg/iceberg_export.h"
#include "iceberg/result.h"
#include "iceberg/table_identifier.h"
#include "iceberg/type_fwd.h"
+#include "iceberg/util/timepoint.h"
namespace iceberg {
+/// \brief Parameters for snapshot selection (time travel).
+struct SnapshotSelection {
+ /// \brief The snapshot ID to read.
+ std::optional<int64_t> snapshot_id;
+ /// \brief Read the snapshot that was current at this timestamp.
+ std::optional<TimePointMs> as_of_timestamp;
Review Comment:
Done. `SnapshotSelection` now uses `std::variant<std::monostate, int64_t,
TimePointMs>`, so snapshot ID and as-of timestamp are mutually exclusive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
