anoopj commented on code in PR #17434:
URL: https://github.com/apache/iceberg/pull/17434#discussion_r3684435122
##########
core/src/main/java/org/apache/iceberg/DeletionVectorStruct.java:
##########
@@ -64,6 +64,12 @@ public String location() {
return location;
}
+ // Package-private only so the manifest reader can store the location
resolved against the
+ // table location; other callers must go through construction.
+ void setLocation(String newLocation) {
+ this.location = newLocation;
+ }
+
Review Comment:
An alternative to exposing the package private `setLocation` method is doing
it through `set` with ordinal. But that would mean computing location's
projected index from the read schema at resolution time and handling the
not-projected case, for both the entry and its nested DV.
The package-private `setLocation` writes the field directly and bypasses the
projection layer, so it's correct and fast regardless of what's projected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
