anoopj commented on code in PR #17434:
URL: https://github.com/apache/iceberg/pull/17434#discussion_r3686387377
##########
core/src/test/java/org/apache/iceberg/TestV4ManifestReader.java:
##########
@@ -114,14 +109,16 @@ class TestV4ManifestReader {
null);
// shared data files: FILE_A is in partition id=1, FILE_B in partition id=2
- private static final TrackedFile FILE_A = dataFile("data-a.parquet",
partition(1));
- private static final TrackedFile FILE_B = dataFile("data-b.parquet",
partition(2));
- private static final TrackedFile EQ_DELETES_A =
deleteFile("eq-deletes-a.parquet", partition(1));
- private static final TrackedFile EQ_DELETES_B =
deleteFile("eq-deletes-b.parquet", partition(2));
+ private static final TrackedFile FILE_A =
dataFile("s3://bucket/data-a.parquet", partition(1));
Review Comment:
I did this way because the reader produces resolved URLs, so it probably
made sense to compare against the contract of expecting absolute URLs. I have
reverted this and added a small `resolved()` test utility method and used it n
the assertions.
##########
core/src/main/java/org/apache/iceberg/V4ManifestReader.java:
##########
@@ -55,16 +57,19 @@ private V4ManifestReader(
Schema readSchema,
Map<Integer, Pair<Evaluator, StructProjection>> partitionFilters,
boolean includeAll,
- ScanMetrics scanMetrics) {
+ ScanMetrics scanMetrics,
+ String tableLocation) {
this.file = file;
this.readSchema = readSchema;
this.partitionFilters = partitionFilters;
this.includeAll = includeAll;
this.scanMetrics = scanMetrics;
+ this.tableLocation = tableLocation;
}
- static Builder builder(InputFile file, Map<Integer, PartitionSpec>
specsById) {
- return new Builder(file, specsById);
+ static Builder builder(
+ InputFile file, Map<Integer, PartitionSpec> specsById, String
tableLocation) {
Review Comment:
Thanks for confirming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
