danielcweeks commented on code in PR #17434:
URL: https://github.com/apache/iceberg/pull/17434#discussion_r3686113899
##########
core/src/main/java/org/apache/iceberg/V4ManifestReader.java:
##########
@@ -55,16 +57,19 @@ private V4ManifestReader(
Schema readSchema,
Map<Integer, Pair<Evaluator, StructProjection>> partitionFilters,
boolean includeAll,
- ScanMetrics scanMetrics) {
+ ScanMetrics scanMetrics,
+ String tableLocation) {
this.file = file;
this.readSchema = readSchema;
this.partitionFilters = partitionFilters;
this.includeAll = includeAll;
this.scanMetrics = scanMetrics;
+ this.tableLocation = tableLocation;
}
- static Builder builder(InputFile file, Map<Integer, PartitionSpec>
specsById) {
- return new Builder(file, specsById);
+ static Builder builder(
+ InputFile file, Map<Integer, PartitionSpec> specsById, String
tableLocation) {
Review Comment:
I think making this required is correct since we either have it from the
existing metadata or it needs to be provided (e.g. by catalog). I don't see a
way of knowing wheater paths are absolute, so this seems reasonable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
