WZhuo commented on code in PR #801:
URL: https://github.com/apache/iceberg-cpp/pull/801#discussion_r3689145925
##########
src/iceberg/inspect/snapshots_table.cc:
##########
@@ -65,4 +68,50 @@ Result<std::unique_ptr<SnapshotsTable>> SnapshotsTable::Make(
return std::unique_ptr<SnapshotsTable>(new SnapshotsTable(std::move(table)));
}
+Result<ArrowArray> SnapshotsTable::Scan(
+ const std::optional<SnapshotSelection>& /*snapshot_selection*/) {
Review Comment:
Done. Snapshot selection is now exposed only by `TimeTravelMetadataTable`.
`SnapshotsTable` inherits `MetadataTable` and exposes only the zero-argument
`Scan()`, so a selector cannot be silently ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
