blackmwk commented on code in PR #2701:
URL: https://github.com/apache/iceberg-rust/pull/2701#discussion_r3746135380
##########
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##########
@@ -54,20 +56,23 @@ pub struct ParquetWriterBuilder {
props: WriterProperties,
schema: SchemaRef,
match_mode: FieldMatchMode,
+ encryption_manager: Option<Arc<EncryptionManager>>,
+ requires_encryption: bool,
Review Comment:
I don't think we need this field, the optional encryption manager is a clear
signal of whether we need encryption.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
