rdblue commented on code in PR #17433:
URL: https://github.com/apache/iceberg/pull/17433#discussion_r3779878519
##########
core/src/main/java/org/apache/iceberg/FieldStatsStruct.java:
##########
@@ -234,6 +228,22 @@ private static int[] posToOffset(Types.StructType struct) {
return posToOffset;
}
+ /**
+ * Copies a bound stored using its internal representation.
Review Comment:
Let's remove unnecessary Javadoc. Nothing here is surprising.
For the description, this is clear from the method name, `copyBound`. In
fact, adding "using its internal representation" makes this more confusing.
I would omit the paragraph below because it leaks implementation details.
That violates our AGENTS.md directive, "Javadoc describes the function or
purpose of a class or method, not the implementation." It's less of an issue
for private methods, but I like to assume that private methods will eventually
leak so it's good to follow best practices.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
