rdblue commented on code in PR #17433:
URL: https://github.com/apache/iceberg/pull/17433#discussion_r3779992392
##########
core/src/main/java/org/apache/iceberg/V4ManifestReader.java:
##########
@@ -322,6 +421,13 @@ private Schema addRequiredColumns(Schema projection,
boolean hasPartitionFilter)
projectedIds.addAll(TypeUtil.getProjectedIds(unionPartitionType));
}
+ // stats needed by the filter or requested by projectStats are read even
when the caller's
+ // projection omits them
Review Comment:
I think this comment can be removed. This determination has already been
made and passed in here as "required stats type". Someone reading this code
doesn't need to know how the required stats were determined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
