uros-b commented on code in PR #17706:
URL: https://github.com/apache/iceberg/pull/17706#discussion_r3801623631
##########
flink/v1.20/flink/src/main/java/org/apache/iceberg/flink/sink/FlinkAppenderFactory.java:
##########
Review Comment:
Nit: `flink/{v1.20,v2.0,v2.1}/FlinkAppenderFactory.java` is removed
entirely, but the PR body describes it as modified ("newPosDeleteWriter now
builds path+pos writers"). The deletion is legitimate, the class is @Deprecated
since 1.11.0, will be removed in favor of FlinkFileWriterFactory, and is
unreferenced in main, but its full removal spans a broader migration than PDWR
removal alone - please confirm the scope and possibly correct the PR body
description accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
