pvary commented on code in PR #17706:
URL: https://github.com/apache/iceberg/pull/17706#discussion_r3802041868
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/source/SparkPositionDeletesRewrite.java:
##########
@@ -230,28 +227,15 @@ public DataWriter<InternalRow> createWriter(int
partitionId, long taskId) {
if (formatVersion >= 3) {
return new DVWriter(table, deleteFileFactory, dsSchema, specId,
partition);
} else {
- Schema positionDeleteRowSchema = positionDeleteRowSchema();
- StructType deleteSparkType = deleteSparkType();
- StructType deleteSparkTypeWithoutRow = deleteSparkTypeWithoutRow();
-
- SparkFileWriterFactory writerFactoryWithRow =
- SparkFileWriterFactory.builderFor(table)
- .deleteFileFormat(format)
- .positionDeleteRowSchema(positionDeleteRowSchema)
- .positionDeleteSparkType(deleteSparkType)
- .writeProperties(writeProperties)
- .build();
- SparkFileWriterFactory writerFactoryWithoutRow =
+ SparkFileWriterFactory writerFactory =
Review Comment:
Same for the other Spark versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
