dramaticlly commented on code in PR #17706:
URL: https://github.com/apache/iceberg/pull/17706#discussion_r3810572118
##########
core/src/main/java/org/apache/iceberg/io/BasePositionDeltaWriter.java:
##########
@@ -65,9 +65,14 @@ public void update(T row, PartitionSpec spec, StructLike
partition) {
updateWriter.write(row, spec, partition);
}
+ /**
+ * @deprecated since 1.12.0, will be removed in 1.13.0; the {@code row} is
ignored, see {@link
+ * PositionDeltaWriter#delete(CharSequence, long, Object, PartitionSpec,
StructLike)}.
Review Comment:
I think we can just keep the Javadoc on interface, removed from
BasepositionDeltaWriter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
