danielcweeks commented on code in PR #17709:
URL: https://github.com/apache/iceberg/pull/17709#discussion_r3805994192


##########
core/src/main/java/org/apache/iceberg/rest/RESTTableScan.java:
##########
@@ -85,6 +87,7 @@ class RESTTableScan extends DataTableScan {
   private final ParserContext parserContext;
   private final Map<String, String> catalogProperties;
   private final Object hadoopConf;
+  private final RemoteSigningConfig remoteSigningConfig;

Review Comment:
   Same here, I don't think this is necessary.  The table ops/fileio is already 
configured for this.  If you're doing remote signing, we don't need to 
reconfigure at this point (also it would just be applying the same 
configuration that was loaded from the catalog).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to