adutra commented on code in PR #17709: URL: https://github.com/apache/iceberg/pull/17709#discussion_r3806247959
########## core/src/main/java/org/apache/iceberg/rest/RemoteSigningProperties.java: ########## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.rest; + +/** + * Remote signing properties. + * + * <p>These properties are automatically set by the REST catalog client when creating table-scoped + * FileIO instances, and are intended for consumption by remote request signers. + * + * <p>They are not intended for user-facing configuration, and may be removed or changed in future + * releases without notice. + */ +public final class RemoteSigningProperties { Review Comment: But they are not meant to be user-facing (as in: they cannot appear in catalog or table configs). Are you OK with that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
