danielcweeks commented on code in PR #17709:
URL: https://github.com/apache/iceberg/pull/17709#discussion_r3806164164
##########
core/src/main/java/org/apache/iceberg/rest/RESTTableScan.java:
##########
@@ -228,7 +234,13 @@ private CloseableIterable<FileScanTask>
planTableScan(PlanTableScanRequest planT
private FileIO scanFileIO(List<Credential> storageCredentials) {
ImmutableMap.Builder<String, String> builder =
- ImmutableMap.<String, String>builder().putAll(catalogProperties);
+ ImmutableMap.<String, String>builder()
Review Comment:
This is a little awkward because we're configuring the remote signing even
when it's not configured. Can't we just add the configuration from the
provided operations (e.g. `putAll(operations.io().properties()))?
Then I don't think we need to push the config all the way down.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
