rdblue commented on code in PR #16936:
URL: https://github.com/apache/iceberg/pull/16936#discussion_r3929711373
##########
core/src/main/java/org/apache/iceberg/GenericManifestFile.java:
##########
@@ -130,6 +132,50 @@ public GenericManifestFile(Schema avroSchema) {
this.partitions = partitions == null ? null : partitions.toArray(new
PartitionFieldSummary[0]);
this.keyMetadata = ByteBuffers.toByteArray(keyMetadata);
this.firstRowId = firstRowId;
+ this.recordCount = null;
+ this.formatVersion = LEGACY_FORMAT_VERSION;
+ }
+
+ /** v4+ constructor variant that accepts recordCount and formatVersion. */
+ GenericManifestFile(
Review Comment:
I don't think that this should be used for v4. Manifests are now stored as
`TrackedFile`. Why would we update the v3 class used to read from manifest
lists?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
