rdblue commented on code in PR #16936: URL: https://github.com/apache/iceberg/pull/16936#discussion_r3929715547
########## core/src/main/java/org/apache/iceberg/GenericManifestFile.java: ########## @@ -60,6 +60,8 @@ public class GenericManifestFile extends SupportsIndexProjection private PartitionFieldSummary[] partitions = null; private byte[] keyMetadata = null; private Long firstRowId = null; + private Long recordCount = null; + private int formatVersion = LEGACY_FORMAT_VERSION; Review Comment: Why update this class when these values are correctly provided by the interface? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
