rdblue commented on code in PR #16936:
URL: https://github.com/apache/iceberg/pull/16936#discussion_r3929749859
##########
core/src/main/java/org/apache/iceberg/TrackedFileAdapters.java:
##########
@@ -53,6 +63,49 @@ static DeleteFile asEqualityDeleteFile(TrackedFile file,
Map<Integer, PartitionS
return new TrackedEqualityDeleteFile(file, resolveSpec(file, specsById));
}
+ /**
+ * Returns a reusable wrapper that presents a {@link DataFile} as a {@link
TrackedFile} row.
+ *
+ * @param formatVersion the target table's format version (must be 4+)
Review Comment:
I don't think this should be passed. We can always add it later when needed.
It also conflicts with how we typically handle writes, which is to have a
version-specific wrapper and keep objects in memory using the latest version's
expectations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
