rdblue commented on code in PR #16025: URL: https://github.com/apache/iceberg/pull/16025#discussion_r3938296100
########## format/spec.md: ########## @@ -546,7 +551,7 @@ Note that: ### Partitioning -Data files are stored in manifests with a tuple of partition values that are used in scans to filter out files that cannot contain records that match the scan’s filter predicate. Partition values for a data file must be the same for all records stored in the data file. (Manifests store data files from any partition, as long as the partition spec is the same for the data files.) +Data files are stored in manifests with partition values that are used in scans to filter out files that cannot contain records that match the scan’s filter predicate. Partition values for a data file must be the same for all records stored in the data file. In v1-v3, manifests store data files from any partition, as long as the partition spec is the same for the data files. In v4, manifests can store data files from different partition specs. Review Comment: "Manifests store data files from any partition" is true, so I'd like to keep the invariant. > Manifests store data files from any partition. v4 manifests may store partitions from any spec, but manifests in v3 and earlier store files for a single spec. Also, why remove "a tuple of"? That is specifying that there are multiple values, not a single value. This is distinguishing Iceberg from Hive, where a "partition" was a string: `"category=explosives/dt=2021-03-09"`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
