amogh-jahagirdar commented on code in PR #16025:
URL: https://github.com/apache/iceberg/pull/16025#discussion_r3972884568


##########
format/spec.md:
##########
@@ -676,13 +691,17 @@ A manifest file must store the partition spec and other 
metadata as properties i
     | _optional_ | _required_ | `format-version`    | Table format version 
number of the manifest as a string                                              
                                       |
     |            | _required_ | `content`           | Type of content files 
tracked by the manifest: "data" or "deletes"                                    
                                      |
 
-#### Content file uniqueness
+=== "v4"
+    | Requirement | Key                 | Value                                
                                                                                
                       |
+    
|-------------|---------------------|---------------------------------------------------------------------------------------------------------------------------------------------|
+    | _optional_  | `schema-id`         | ID of the schema used to write the 
manifest as a string                                                            
                         |
+    | _optional_  | `format-version`    | Table format version number of the 
manifest as a string                                                            
                         |
 
-Within a snapshot, each content file must be referenced by at most one live 
manifest entry across all manifests; otherwise, the snapshot has undefined 
behavior. Writers should not produce multiple manifest entries for the same 
content file in a snapshot (for example, both ADDED and DELETED entries for the 
same file). Writers are not required to validate uniqueness at commit time.
+The schema of a manifest file is defined by the `manifest_entry` struct 
(v1-v3) or `content_entry` struct (v4), described in the following section.
 
-#### Manifest Entry Fields
+#### Entries in Manifests
 
-The schema of a manifest file is defined by the `manifest_entry` struct, which 
consists of the following fields:
+In v1-v3, manifest entries are described by the `manifest_entry` struct. In 
v4, entries are called content entries and are described by the `content_entry` 
struct. In v4, `data_file` struct fields are flattened directly into the 
content entry, and tracking fields are grouped into a nested `tracking` struct.

Review Comment:
   content_entries -> tracked_file. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to