rdblue commented on code in PR #16025: URL: https://github.com/apache/iceberg/pull/16025#discussion_r3938308594
########## format/spec.md: ########## @@ -656,15 +661,22 @@ A data or delete file is associated with a sort order by the sort order's id wit ### Manifests -A manifest is an immutable Avro file that lists data files or delete files, along with each file’s partition data tuple, metrics, and tracking information. One or more manifest files are used to store a [snapshot](#snapshots), which tracks all of the files in a table at some point in time. Manifests are tracked by a [manifest list](#manifest-lists) for each table snapshot. +A manifest is an immutable file that lists data files or delete files, along with each file’s partition data, metrics, and tracking information. One or more manifest files are used to store a [snapshot](#snapshots), which tracks all of the files in a table at some point in time. In v1-v3, manifests are tracked by a [manifest list](#manifest-lists) for each table snapshot. In v4, a single root manifest per snapshot can directly reference data files, delete files, and other data and delete manifests. Review Comment: Similar to the comment above, I'd phrase this first using what is common: > Manifests are tracked by a root metadata file for each table snapshot. In v4, the root metadata file is a root manifest that may track data files in addition to leaf manifest files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
