kevinjqliu commented on code in PR #3184:
URL: https://github.com/apache/iceberg-rust/pull/3184#discussion_r3975954976
##########
crates/property-macro/Cargo.toml:
##########
@@ -40,7 +40,9 @@ quote = { workspace = true }
syn = { workspace = true, features = ["full"] }
[dev-dependencies]
-iceberg = { workspace = true }
+# Path-only so cargo strips it when packaging; a versioned dev-dependency would
+# create a publish cycle, since `iceberg` depends on this crate.
+iceberg = { path = "../iceberg" }
Review Comment:
this is the main fix
##########
crates/property-macro/Cargo.toml:
##########
@@ -28,7 +28,7 @@ license = { workspace = true }
repository = { workspace = true }
categories = ["database"]
-description = "Property derive macro for Apache Iceberg Rust"
+description = "Apache Iceberg Rust property macros, internal to the iceberg
crate"
Review Comment:
i feel like its a good idea to call this out as "internal", but happy to
revert
##########
.github/workflows/ci.yml:
##########
@@ -152,6 +152,11 @@ jobs:
cargo check -p "$pkg" --all-targets || exit 1
done
+ # Dry-runs the publish.yml command to catch crates that cannot be
published,
+ # such as packages missing files or dependency cycles between workspace
crates.
+ - name: Check each crate can be published
+ run: cargo publish --workspace --all-features --dry-run
Review Comment:
this will ensure we catch similar issue in CI time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
