dannycjones commented on code in PR #3184:
URL: https://github.com/apache/iceberg-rust/pull/3184#discussion_r3982591558
##########
website/src/release.md:
##########
@@ -214,6 +215,7 @@ This script creates:
- SHA-512 checksum: `apache-iceberg-rust-${iceberg_version}.tar.gz.sha512`
- Signed annotated RC tag: `v${iceberg_version}-rc.${rc}`
+The publish dry-run packages and builds every crate as the final release
would, so a crate that cannot be published fails RC creation.
The script checks license headers against the generated source archive, not
the live Git worktree. If enabled, SVN upload runs after local artifact
verification and before RC tag creation. The script creates the signed RC tag
as the final release step, then prints a draft VOTE email for
`[email protected]`.
Review Comment:
I think we could reword for readability
```suggestion
The script runs a number of verifications.
It performs a dry-run packaging step and builds every crate as the final
release would, so a crate that cannot be published fails RC creation.
It also checks license headers against the generated source archive.
If enabled, SVN upload runs after local artifact verification and before RC
tag creation. The script creates the signed RC tag as the final release step,
then prints a draft VOTE email for `[email protected]`.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
