dannycjones commented on code in PR #3184:
URL: https://github.com/apache/iceberg-rust/pull/3184#discussion_r3977624845
##########
crates/property-macro/Cargo.toml:
##########
@@ -40,7 +40,9 @@ quote = { workspace = true }
syn = { workspace = true, features = ["full"] }
[dev-dependencies]
-iceberg = { workspace = true }
+# Path-only so cargo strips it when packaging; a versioned dev-dependency would
+# create a publish cycle, since `iceberg` depends on this crate.
+iceberg = { path = "../iceberg" }
Review Comment:
I suppose we could have kept both here, but I don't see any additional value
in maintaining the non-path dependency. lgtm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
