kbendick commented on a change in pull request #2062:
URL: https://github.com/apache/iceberg/pull/2062#discussion_r557859899
##########
File path:
api/src/main/java/org/apache/iceberg/expressions/BoundLiteralPredicate.java
##########
@@ -91,6 +93,8 @@ public String toString() {
return term() + " != " + literal;
case STARTS_WITH:
return term() + " startsWith \"" + literal + "\"";
+ case NOT_STARTS_WITH:
+ return term() + " notStartsWith \"" + literal + "\"";
Review comment:
I think it's best that we follow up on this once it's merged. I'd prefer
to not change too much of the existing behavior so as to give this PR the most
opportunity to get approved and merged in.
Then we can evaluate whether or not the toString representation is over
quoted. Thankfully, it does not appear that the toString representation of the
bound literal term affects the results of the operation, at least based on my
running through several of the tests with the debugger.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
