kbendick commented on a change in pull request #2062:
URL: https://github.com/apache/iceberg/pull/2062#discussion_r557860590
##########
File path:
api/src/main/java/org/apache/iceberg/expressions/StrictMetricsEvaluator.java
##########
@@ -402,6 +402,11 @@ public Boolean or(Boolean leftResult, Boolean rightResult)
{
return ROWS_MIGHT_NOT_MATCH;
}
+ @Override
+ public <T> Boolean notStartsWith(BoundReference<T> ref, Literal<T> lit) {
+ return ROWS_MIGHT_NOT_MATCH;
Review comment:
There's a TODO - `// TODO: Handle cases that definitely cannot match,
such as notStartsWith("x") when the bounds are ["a", "b"].` - and once this is
merged I'll be sure to open an issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
