kbendick commented on a change in pull request #2062:
URL: https://github.com/apache/iceberg/pull/2062#discussion_r559263994
##########
File path: spark3/src/main/java/org/apache/iceberg/spark/Spark3Util.java
##########
@@ -579,6 +579,8 @@ public String or(String leftResult, String rightResult) {
return pred.ref().name() + " != " + sqlString(pred.literal());
case STARTS_WITH:
return pred.ref().name() + " LIKE '" + pred.literal() + "%'";
+ case NOT_STARTS_WITH:
+ return pred.ref().name() + " NOT LIKE '" + pred.literal() + "%'";
Review comment:
Resolving this coversation as there is already a follow up issue
https://github.com/apache/iceberg/issues/2059. I'll mention that `Spark3Util`
shouuld be considered when working on that issue as a follow up.
##########
File path: spark3/src/main/java/org/apache/iceberg/spark/Spark3Util.java
##########
@@ -579,6 +579,8 @@ public String or(String leftResult, String rightResult) {
return pred.ref().name() + " != " + sqlString(pred.literal());
case STARTS_WITH:
return pred.ref().name() + " LIKE '" + pred.literal() + "%'";
+ case NOT_STARTS_WITH:
+ return pred.ref().name() + " NOT LIKE '" + pred.literal() + "%'";
Review comment:
Resolving this conversation as there is already a follow up issue
https://github.com/apache/iceberg/issues/2059. I'll mention that `Spark3Util`
shouuld be considered when working on that issue as a follow up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
