pvary commented on a change in pull request #2325:
URL: https://github.com/apache/iceberg/pull/2325#discussion_r592615110
##########
File path: hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
##########
@@ -604,4 +596,34 @@ public void setConf(Configuration conf) {
public Configuration getConf() {
return conf;
}
+
+ @VisibleForTesting
+ HiveClientPool loadHiveClientPool(Configuration configuration) {
Review comment:
Could we just call it `clientPool`? I would prefer not to "leak"
information about how it is handled internally.
Also HiveCatalog has a `conf`, do we really need a new `configuration`
object?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
