lcspinter commented on a change in pull request #2325:
URL: https://github.com/apache/iceberg/pull/2325#discussion_r592700382
##########
File path:
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java
##########
@@ -400,6 +401,20 @@ public void testTableName() {
}
}
+ @Test
+ public void testClientPoolCleaner() throws InterruptedException {
+ HiveCatalog catalog = new HiveCatalog(hiveConf);
+ HiveClientPool clientPool1 = catalog.loadHiveClientPool(hiveConf);
+ Thread.sleep(TimeUnit.SECONDS.toMillis(5));
Review comment:
I choose Thread.sleep() because we are using this pattern in other test
suits as well. Anyway, I changed this part to TimeUnit.SECONDS.sleep() for
better readability.
##########
File path:
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveMetastore.java
##########
@@ -215,6 +216,8 @@ private void initConf(HiveConf conf, int port) {
conf.set(HiveConf.ConfVars.METASTORE_TRY_DIRECT_SQL.varname, "false");
conf.set(HiveConf.ConfVars.METASTORE_DISALLOW_INCOMPATIBLE_COL_TYPE_CHANGES.varname,
"false");
conf.set("iceberg.hive.client-pool-size", "2");
+ conf.setLong("iceberg.hive.client-pool-cache-cleaner-interval",
TimeUnit.SECONDS.toMillis(5));
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
