nastra commented on a change in pull request #2826:
URL: https://github.com/apache/iceberg/pull/2826#discussion_r673867234
##########
File path: core/src/main/java/org/apache/iceberg/BaseTransaction.java
##########
@@ -454,6 +454,7 @@ public TableMetadata refresh() {
}
@Override
+ @SuppressWarnings("ConsistentOverrides")
public void commit(TableMetadata underlyingBase, TableMetadata metadata) {
Review comment:
renaming `underlyingBase` to `base` here does conflict and shadows the
`base` variable that's defined in the class itself
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
