rdblue commented on a change in pull request #2826:
URL: https://github.com/apache/iceberg/pull/2826#discussion_r676750640
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedParquetDefinitionLevelReader.java
##########
@@ -305,7 +305,7 @@ public void nextDictEncodedBatch(
protected abstract void nextVal(
FieldVector vector, int idx, ValuesAsBytesReader valuesReader, int
typeWidth, byte[] byteArray);
protected abstract void nextDictEncodedVal(
- FieldVector vector, int startOffset,
VectorizedDictionaryEncodedParquetValuesReader reader,
+ FieldVector vector, int idx,
VectorizedDictionaryEncodedParquetValuesReader reader,
Review comment:
Do you know why this is needed now? I thought we already caught variable
names that shadow field names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
