nastra commented on a change in pull request #2826:
URL: https://github.com/apache/iceberg/pull/2826#discussion_r676327356
##########
File path:
api/src/main/java/org/apache/iceberg/expressions/StrictMetricsEvaluator.java
##########
@@ -429,7 +429,7 @@ public Boolean or(Boolean leftResult, Boolean rightResult) {
}
private boolean canContainNulls(Integer id) {
- return nullCounts == null || (nullCounts.containsKey(id) &&
nullCounts.get(id) > 0);
+ return nullCounts == null || nullCounts.containsKey(id) &&
nullCounts.get(id) > 0;
Review comment:
@rdblue pushed a new version where the `UnnecessaryParentheses`
checkstyle module was removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
