rdblue commented on a change in pull request #2826:
URL: https://github.com/apache/iceberg/pull/2826#discussion_r677678017
##########
File path: build.gradle
##########
@@ -247,13 +250,30 @@ project(':iceberg-data') {
exclude group: 'org.slf4j', module: 'slf4j-log4j12'
}
- testCompile("org.apache.hadoop:hadoop-client") {
+ implementation("org.apache.orc:orc-core::nohive") {
Review comment:
This adds implementation dependencies for org.apache.avro:avro and
org.apache.orc:orc-core. Why isn't there one for org.apache.parquet?
Can you be more specific about what you're saying with implementation vs
compile? When are transitive dependencies included and when are they not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
