RussellSpitzer commented on a change in pull request #3914:
URL: https://github.com/apache/iceberg/pull/3914#discussion_r790769233
##########
File path:
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
##########
@@ -262,7 +262,8 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
Map<String, String> summary =
Optional.ofNullable(metadata.currentSnapshot())
.map(Snapshot::summary)
.orElseGet(ImmutableMap::of);
- setHmsTableParameters(newMetadataLocation, tbl, metadata.properties(),
removedProps, hiveEngineEnabled, summary);
+ setHmsTableParameters(newMetadataLocation, tbl, metadata.properties(),
removedProps, hiveEngineEnabled, summary,
Review comment:
~I wonder if we should be passing through the metadata here instead of
`"tbl, metadata.properties and uuid"`~
Forgot which table this was. I still think we should probably pass through
`metadata` instead of `metadata.properties` and `uuid` now that we use both
things. Not a big deal though if you want to leave it as separate parameters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
