RussellSpitzer commented on a change in pull request #3914:
URL: https://github.com/apache/iceberg/pull/3914#discussion_r790773459
##########
File path:
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerNoScan.java
##########
@@ -662,7 +662,7 @@ public void testIcebergAndHmsTableProperties() throws
Exception {
.collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue));
if (Catalogs.hiveCatalog(shell.getHiveConf(), tableProperties)) {
- Assert.assertEquals(13, hmsParams.size()); // 2 newly-added properties +
previous_metadata_location prop
+ Assert.assertEquals(14, hmsParams.size()); // 2 newly-added properties +
previous_metadata_location prop
Review comment:
Nit: Could we convert 14 -> an expression that calculates the expected
number of properties rather than having to manually change this whenever we add
new properties?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
