flyrain commented on a change in pull request #3914:
URL: https://github.com/apache/iceberg/pull/3914#discussion_r791040798
##########
File path:
mr/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerNoScan.java
##########
@@ -662,7 +662,7 @@ public void testIcebergAndHmsTableProperties() throws
Exception {
.collect(Collectors.toMap(Map.Entry::getKey, Map.Entry::getValue));
if (Catalogs.hiveCatalog(shell.getHiveConf(), tableProperties)) {
- Assert.assertEquals(13, hmsParams.size()); // 2 newly-added properties +
previous_metadata_location prop
+ Assert.assertEquals(14, hmsParams.size()); // 2 newly-added properties +
previous_metadata_location prop
Review comment:
It makes sense to avoid magic number. Here, I'd just leave it as is.
Adding a reserved table property doesn't happen frequently. I'd avoid a smart
solution to calculate the property number, which add complexity to the unit
test. But I'm also open to any nice solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
