rdblue commented on a change in pull request #4307:
URL: https://github.com/apache/iceberg/pull/4307#discussion_r825474667
##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -167,6 +167,9 @@ private TableProperties() {
public static final String ORC_BATCH_SIZE =
"read.orc.vectorization.batch-size";
public static final int ORC_BATCH_SIZE_DEFAULT = 5000;
+ public static final String INCLUDE_HIDDEN_PATHS =
"read.fs.include-hidden-paths";
+ public static final boolean INCLUDE_HIDDEN_PATHS_DEFAULT = false;
Review comment:
I don't think that this is a good candidate for a table property.
Instead, I think it should be an option on the `DeleteOrphanFiles` action:
```java
SparkActions.get(spark)
.deleteOrphanFiles(table)
.option("ignore-hidden-paths", "false")
.execute();
```
Table properties are used for more generally useful options. But this one is
fairly specific to the action itself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
