kbendick commented on a change in pull request #4307:
URL: https://github.com/apache/iceberg/pull/4307#discussion_r824073765
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/actions/BaseDeleteOrphanFilesSparkAction.java
##########
@@ -124,25 +129,25 @@ protected DeleteOrphanFiles self() {
@Override
public BaseDeleteOrphanFilesSparkAction executeDeleteWith(ExecutorService
executorService) {
- this.deleteExecutorService = executorService;
Review comment:
Nit: Typically we try to keep our changes to the minimum number of lines
possible. So not including any updates on the lines that aren't actually
changed (even if they would fix a style issue - we keep that in a separate PR).
However, in this case, we do use `this` as we are assigning the class
variable. When assigning, we do use `this`.
##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -167,6 +167,9 @@ private TableProperties() {
public static final String ORC_BATCH_SIZE =
"read.orc.vectorization.batch-size";
public static final int ORC_BATCH_SIZE_DEFAULT = 5000;
+ public static final String INCLUDE_HIDDEN_PATHS =
"read.fs.include-hidden-paths";
+ public static final boolean INCLUDE_HIDDEN_PATHS_DEFAULT = false;
Review comment:
I'm not sure if this should be a table property - although it is
tempting to generally use table properties, we don't really want them to grow
without bounds.
Seems like something we should keep as a property to the action.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
