kbendick commented on a change in pull request #4307:
URL: https://github.com/apache/iceberg/pull/4307#discussion_r828132329
##########
File path:
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/actions/BaseDeleteOrphanFilesSparkAction.java
##########
@@ -191,9 +196,10 @@ private String jobDesc() {
List<String> matchingFiles = Lists.newArrayList();
Predicate<FileStatus> predicate = file -> file.getModificationTime() <
olderThanTimestamp;
+ PathFilter filter = pathFilter(table.spec());
Review comment:
It's a bit confusing to me to have both `predicate` and `filter`,
especially as variables passed to the same function.
I know `pathFilter` is the name of the function, but would it make sense to
name this variable as `pathFilter` and the function as something like
`buildPathFilter` or `inferHiddenPathFilter`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
