kbendick commented on code in PR #4649:
URL: https://github.com/apache/iceberg/pull/4649#discussion_r860209690
##########
flink/v1.13/flink/src/main/java/org/apache/iceberg/flink/FlinkDynamicTableFactory.java:
##########
@@ -142,6 +143,12 @@ public Set<ConfigOption<?>> optionalOptions() {
Set<ConfigOption<?>> options = Sets.newHashSet();
options.add(CATALOG_DATABASE);
options.add(CATALOG_TABLE);
+ options.add(FlinkLookupOptions.LOOKUP_CACHE_MAX_ROWS);
+ options.add(FlinkLookupOptions.LOOKUP_CACHE_TTL);
+ options.add(FlinkLookupOptions.LOOKUP_CACHE_IGNORE_EMPTY);
+ options.add(FlinkLookupOptions.LOOKUP_MAX_RETRIES);
+ options.add(FlinkLookupOptions.LOOKUP_BASE_RETRY_BACKOFF_MILLS);
+ options.add(FlinkLookupOptions.LOOKUP_MAX_RETRY_BACKOFF_MILLS);
Review Comment:
Usually, we implement new features against just the latest version (in this
case, Flink 1.14).
This makes reviewing easier as there isn't code duplication and comments
aren't split across two sets of files.
Then, after everything is reviewed and merged, we back port to previous
versions.
Is it possible to keep this just to Flink 1.14 for now?
##########
bundled-guava/src/main/java/org/apache/iceberg/GuavaClasses.java:
##########
@@ -94,6 +96,8 @@ public class GuavaClasses {
Iterables.class.getName();
CountingOutputStream.class.getName();
Suppliers.class.getName();
+ Cache.class.getName();
+ CacheBuilder.class.getName();
Review Comment:
Usually we use the [`Caffeine`
caches](https://github.com/ben-manes/caffeine) instead (which mostly have the
same API as Guava's).
Is there a reason that `Caffeine` won't work here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
