samredai commented on code in PR #4649: URL: https://github.com/apache/iceberg/pull/4649#discussion_r864395153
########## docs/flink/flink-connector.md: ########## @@ -141,5 +147,16 @@ SELECT * FROM flink_table; +----+------+ 3 rows in set ``` +## Lookup Join Review Comment: Shouldn't this be next to the Flink SQL content? I don't like that all of Flink SQL is covered in a page called "Getting Started" but I think that section should be broken into two: "SQL" and "DataStream", in which case this will go in the "SQL" section. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
