hailin0 commented on code in PR #4649:
URL: https://github.com/apache/iceberg/pull/4649#discussion_r864888301
##########
flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/FlinkDynamicTableFactory.java:
##########
@@ -142,6 +143,12 @@ public Set<ConfigOption<?>> optionalOptions() {
Set<ConfigOption<?>> options = Sets.newHashSet();
options.add(CATALOG_DATABASE);
options.add(CATALOG_TABLE);
+ options.add(FlinkLookupOptions.LOOKUP_CACHE_MAX_ROWS);
+ options.add(FlinkLookupOptions.LOOKUP_CACHE_TTL);
+ options.add(FlinkLookupOptions.LOOKUP_CACHE_IGNORE_EMPTY);
+ options.add(FlinkLookupOptions.LOOKUP_MAX_RETRIES);
+ options.add(FlinkLookupOptions.LOOKUP_BASE_RETRY_BACKOFF_MILLS);
+ options.add(FlinkLookupOptions.LOOKUP_MAX_RETRY_BACKOFF_MILLS);
Review Comment:
sorry, i don't understand what you mean.
FlinkLookupFunction#eval method has no return value, how to cache function
return value?
referenceļ¼
https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-hbase-base/src/main/java/org/apache/flink/connector/hbase/source/HBaseRowDataLookupFunction.java#L96
https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/table/JdbcRowDataLookupFunction.java#L146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
